Feature/camera worker proxyless

TeamTetris / tetris-game

2 stars 0 forks source link

Feature/camera worker proxyless #26

Closed julianweise closed 6 years ago

julianweise commented 6 years ago

This PR will add the the following functionalities, wrapped into our Service/Profile/Profiler concept:

DialogService Enables generic use of dialogs
FaceAnalysisService _Enables communication of our WebApp with Face++ by sending base64 images__
CamerController Responsible for requesting images from the user's webcam

julianweise commented 6 years ago

@friedow Thanks for your detailed review. Please have another look at it. I am curious what your opinion is regarding the await vs typing issue.

julianweise commented 6 years ago

@friedow I just pushed a commit that replaces all then() functions by the usage of await. Nevertheless, using try/catch, as you suggested, retains the original nesting level and therefore contradicts your motivation to introduce await.

friedow commented 6 years ago

I see your point that try / catch increases the nesting level again but I think the refactored code is a huge improvement anyway. Nice refactoring :), it just reads much more smoothly.

Alt Text

Johannes-Schneider commented 6 years ago

I just rebased our branch on the current developer. Additionally, I included Max's feedback.