TeamTotemic / Totemic

A Minecraft mod that allows you to control the world through the power of Totem Poles
https://www.curseforge.com/minecraft/mc-mods/totemic
MIT License
29 stars 21 forks source link

To many Medicine Men #106

Closed Hexblood closed 1 year ago

Hexblood commented 5 years ago

Minecraft version: 1.12.2 Forge version: 14.23.5.2836 Totemic version: 1.12.2-0.11.6

Issue: The weight of the Medicine Men is very high. Exploring worlds on a few versions of the mod have yielded the same result. Villages are half or more made up of Medicine Men. This is throwing off access to Vanilla Villagers.

Suggested fix: Limit Medicine Man spawns to 1-2 per village and/or give a config setting to adjust the spawn chance of Medicine Men.

ljfa-ag commented 2 years ago

I can't directly adjust the spawn rates of Medicine Men, since the villager profession is chosen uniformly randomly. The problem is probably that Medicine Wheels and Tipis always spawn a Medicine Man. I will probably not be changing this for the 1.12 version soon. The workaround would be to disable spawning of Tipis and Medicine Wheels in the config.

ljfa-ag commented 2 years ago

I changed my mind, I will be addressing this by not (solely) spawning Medicine Men in Tipis and Medicine Wheels.

ljfa-ag commented 1 year ago

Some investigation yielded that after removing the Medicine Men spawns from Totemic's village structures, the villages are still mostly made up of Medicine Men. The RNG used to choose random villager professions seems to always return the same value. I can't figure why this is happening but it might actually be a Forge bug.

ljfa-ag commented 1 year ago

I made an attempt to solve the underlying issue, the fix can be activated with a config option. Or, Medicine Men can be disabled in the config altogether.