search

TeamTwilight / twilightforest

Twilight Forest repository
Other
670 stars 197 forks source link

Magic Core sounds configuration #2249

Closed AriaElidove closed 2 months ago

AriaElidove commented 2 months ago

The Suggestion

Make Magic Core sounds disabled via config if a player choose to

Why Should It Be in the Mod?

I don't want to constant hear "beep, boop, beep, beep" and "tick tick tick tick" while debugging things regarding the cores

Please Read and Confirm the Following

LiteWolf101 commented 2 months ago

Why do that when there's a mod that has this ability for you?

Extreme Sound Muffler

I don't think it would be a good idea to have sounds for a mod as big as this to have a configuration entry just for disabling.

AriaElidove commented 2 months ago

Because I rather not learn how Intellij handles adding mods for Run Client

Tamaized commented 2 months ago

You.... Just put the mod in the mods folder ...

Fooshcookie commented 2 months ago

You.... Just put the mod in the mods folder ...

Uhmzm,, no#'?

Tamaized commented 2 months ago

Yes

$project/run/mods

Drullkus commented 2 months ago

Fantastic find, @LiteWolf101! For anyone else curious, I dropped it into the directory that Tama posted -- It works 🎉

Screenshot 2024-09-01 at 10 34 12 AM
AriaElidove commented 2 months ago

Yea that does just work. The last times I tried something like this it just would not function, so thank you.

Following this, should yall just... remove the cicada sfx config then? Seeing as this is an option: image

Tamaized commented 2 months ago

Nah

GizmoTheMoonPig commented 2 months ago

the main difference between the core sounds and the cicada sounds is that theres no way to control the cicada volume without the use of external tools like the sound muffler. While it is a legacy config option from the old MC sound engine days, its still good to have for people since they dont play on a certain sound channel and cant be quieted without changing the master volume