TeamTwilight / twilightforest

Twilight Forest repository
Other
671 stars 198 forks source link

Biome-blending cannot be disabled for dark leaves #2273

Open Lolothepro opened 2 months ago

Lolothepro commented 2 months ago

NeoForge Version

21.1.64

Twilight Forest Version

4.6.2790

Client Log

https://mclo.gs/Az2icCw

Crash Report (if applicable)

No response

Steps to Reproduce

Go to the border between the “dark_forest” biome and the “dark_forest_center” biome Press Esc Go to video settings and set “Biome Blending” to “Off”.

What You Expected

No biome-blending

What Happened Instead

The color of the leaves is still blended

Additional Details

2024-09-29_12 03 32

Please Read and Confirm The Following

Andromander commented 1 month ago

This appears to be how Dark Leaves - and to this extent, Giant Leaves - are tinted.

Long story short: the blend radius setting is working.

Short story long: It works, but only if we just got the average foliage colour and called it a day. Instead, an average is picked from a small radius around the block itself. That basically means blending is always present, but if "disabled", the blending is only slightly less so than if it were enabled. It appears to be a 1-block radius from the center, so an average of all the foliage colour in a 3x3 area. As for why, I can't really explain it, tbh. Someone else that may have ported the mod to 1.12 might know.

No Biome Blending: 2024-10-12_21 52 47

Normal Biome Blending: 2024-10-12_21 52 56