search

TeamTwilight / twilightforest

Twilight Forest repository
Other
670 stars 196 forks source link

Loss of hotbar and inventory with Charm of Keeping and PlayerRevive mod #576

Closed bmwalter68 closed 6 years ago

bmwalter68 commented 6 years ago

Forge version: 14.23.4.2705 Twilight Forest version: 1.12.2-3.8.559 Link to crash log: not a crash

Steps to reproduce:

What I expected to happen:

On both single and multi player I expect all items to drop when the Charm of Keeping III is not equipped and for all inventory to be equipped after death when it is equipped. Also, there appears to be a visual effect when the charm 'Does it's Thing (tm)' on player respawn which should happen in both single and multi player.

What happened instead:

When the player has Charm of Keeping III equipped in multi player, baubles are correctly kept through death but the players hotbar and inventory items do not drop. There is also no visual effect on respawn. This appears to be a conflict with the way PlayerRevive handles giving an opportunity for the player to avoid death by being revived by another player. Removing PlayerRevive resolves the issue.

My first thought was this was a PlayerRevive issue, but I can only make it happen with the Charm of Keeping.

bs2609 commented 6 years ago

Probably a similar issue to #338 then. Can you see if build 560 fixes this?

bmwalter68 commented 6 years ago

Build 560 does appear to fix this issue. Single and multi player dedicated are behaving as intended, including the visual effect.

Just out of curiosity, do you have any idea when a release (beta would be fine) with this fix would go live on Curse? They don't let anyone publish modpacks with dev releases in them. Not rushing you in any way, believe me I know how that goes... You guys are really super responsive! I'm just trying to decide if I should go ahead and push a version of my pack with PlayerRevive removed so no more inventory goes poof.