search

TeamUlysses / ulib

ULib: A Lua library for more rapid development on Garry's Mod servers
http://ulyssesmod.net
Other
105 stars 55 forks source link

ban length on disconnect message show an hour as 59 minutes #14

Closed fruitwasp closed 8 years ago

fruitwasp commented 8 years ago

Steps to reproduce

  1. ban a player for an hour.

    Expected behavior

ban length on disconnect message should show 60 minutes or 1 hour.

Actual behavior

ban length on disconnect message shows 59 minutes

Version

ULib v2.52d (01/09/16) ULX v3.62d (01/01/16)

Extra

Code causing it: https://github.com/TeamUlysses/ulib/blob/5652d868bab0848abaf682f75b92871033a26bbe/lua/ulib/shared/misc.lua#L830

The converted time is only used as a string on the disconnect message, therefore I don't see why.

Nayruden commented 8 years ago

Huh, that seems like something I probably had some reason for the way I implemented it, but I don't remember why.

Nayruden commented 8 years ago

Closed with 2bb1db40770b469983ec89956c46e7fb3ea1d1f2