search

TeamUlysses / ulib

ULib: A Lua library for more rapid development on Garry's Mod servers
http://ulyssesmod.net
Other
104 stars 55 forks source link

Update commands.lua #35

Closed cannon closed 6 years ago

cannon commented 7 years ago

Fix a lag exploit from spamming "_u foo" and having the server console flooded with "Unknown command: foo"

Nayruden commented 7 years ago

Thank you for your interest in improving ULib! Unless I'm missing something, this saves one function call; did you test the change to see if there was a noticeable impact with this change?

Nayruden commented 7 years ago

Ah, I see. We will look into this more.

On Sun, Aug 6, 2017 at 12:52 PM, ghost0123 notifications@github.com wrote:

Facepunch/garrysmod-issues#3258 (comment) https://github.com/Facepunch/garrysmod-issues/issues/3258#issuecomment-320484796

https://facepunch.com/showthread.php?t=1574081

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TeamUlysses/ulib/pull/35#issuecomment-320521820, or mute the thread https://github.com/notifications/unsubscribe-auth/AABAz33xZ4btLoUAR53jM8gH0Lf5HtAgks5sVf1fgaJpZM4Ouoxb .

cannon commented 7 years ago

The main purpose of this change is to avoid printing "Unknown command" when the command is not found.

SticklyMan commented 6 years ago

Thanks for the contribution! We opted to fix this in an alternate, more direct way, which is now on our master branch: 58659ac275caffbaa689d5e835e7079f1128e1be