TeamUlysses / ulx

ULX: A powerful administration addon for Garry's Mod
https://ulyssesmod.net
Other
163 stars 73 forks source link

Allow use of SteamIDs in `!xban` when user has `ulx ban` but not `ulx banid` #225

Open JoshuaLeivers opened 4 months ago

JoshuaLeivers commented 4 months ago

Steps to reproduce

  1. Have access to ulx ban, but not ulx banid
  2. Use !xban
  3. See that the SteamID field is greyed out and inaccessible

Expected behavior

The field is accessible, but only lets you ban people as if you ran it via ulx ban $STEAM_BLAH, rather than ulx banid STEAM_BLAH - i.e. no offline bans, and with permission checking.

Actual behavior

Field is inaccessible, as it only allows the use of ulx banid, and so is only enabled if the user has permission to use that.

image

Version

ULib v2.71d (08/05/22) ULX v3.81d (03/24/24)

Notes

This is more a feature request than a bug, despite what this format suggests. It would be nice to allow people to use SteamIDs via xban, as you already can use SteamIDs via ulx ban $ID, it's just not exactly the same as ulx banid.

Nayruden commented 4 months ago

Hi JoshuaLeivers,

Given that ulx ban $ID only lets you ban users by ID if they're currently on the server, wouldn't it be far more annoying to grab their ID to put into that field instead of using the dropdown?

JoshuaLeivers commented 4 months ago

Hi JoshuaLeivers,

Given that ulx ban $ID only lets you ban users by ID if they're currently on the server, wouldn't it be far more annoying to grab their ID to put into that field instead of using the dropdown?

Possibly, but it just means that people have another option to use. For example, on a server I moderate on, I usually have the person's SteamID copied already for other things, or can very easily get it, and it's simply easier to use the SteamID I already have, rather than searching through the names again to target them.

zpetty33 commented 4 months ago

Hello JoshuaLeivers, We've done some internal testing to verify what you were asking. While we do see some value in adding this, it would not be something we act on immediately. This will go onto our to-do list for a possible future feature addition. Thank you for the input.