search

TeamVanced / Integrations

Open Source integrations for Vanced (SponsorBlock and Return YouTube Dislikes)
34 stars 16 forks source link

remove thread check from PlayerController.setCurrentVideoId #24

Closed sebm253 closed 3 years ago

sebm253 commented 3 years ago

while i realize that this check probably had (and maybe still has?) a meaning, it's essential for the fix for the video id not getting overriden when watching shorts: https://canary.discord.com/channels/328493314485518336/745695354447462440/834493238898589766

from my testing, there were no exceptions after removing this check. however if you think it should stay there, i'll need to find another way, though realistically i can't imagine any concurrency issues there

KevinX8 commented 3 years ago

merged for now, might remove if it causes issues

jakweg commented 3 years ago

I think it had something to do with older version if it works without that. Downloading is done in async method, so there is no UI blocking. I think it's safe to remove that, though if there were any crashes we might try adding this check again.