search

TeamWanari / rosetta

Flutter Localization tool with code generation tool.
MIT License
35 stars 7 forks source link

0.2.2 does not compile #68

Closed noordawod closed 3 years ago

noordawod commented 3 years ago

The current version does not compile when nullsafety is engaged.

The reason is that pubspec.yaml broadcasts dependency on Dart 2.10+ which has nullsafety ON by default. In comparison, the previous version 0.2.0 relied on Dart 2.6.0 which had nullsafety but it was OFF by default.

To fix, merely update the version back to 2.6.0 and everything works.

I can submit a pr to update this and publish a 0.2.3 of Rosetta and its generator. What do you say?

l4ty4k commented 3 years ago

Yeah, this was an error on our side. We'd appreciate the PR, so please submit it.

We already working on migrating the project to null_safety, but one of the dev dependency (build_runner) is yet to migrate. So as soon as possible we will release a null_safe version.

noordawod commented 3 years ago

Here you go: https://github.com/TeamWanari/rosetta/pull/69

noordawod commented 3 years ago

Thanks for the quick merge!