TeamWertarbyte / material-ui-chip-input

A chip input field using Material-UI.
https://mui.wertarbyte.com/#material-ui-chip-input
MIT License
737 stars 208 forks source link

Please add React 17 support #361

Open bodqhrohro opened 3 years ago

bodqhrohro commented 3 years ago

I run into a dependency conflict currently:

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!   peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.12.3
npm ERR!   node_modules/@material-ui/core
npm ERR!     @material-ui/core@"^4.11.2" from the root project
npm ERR!     peer @material-ui/core@"^4.0.0" from material-ui-chip-input@2.0.0-beta.2
npm ERR!     node_modules/material-ui-chip-input
npm ERR!       material-ui-chip-input@"^2.0.0-beta.2" from the root project
npm ERR!   1 more (react-dom)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.6" from material-ui-chip-input@2.0.0-beta.2
npm ERR! node_modules/material-ui-chip-input
npm ERR!   material-ui-chip-input@"^2.0.0-beta.2" from the root project
rn2web commented 2 years ago

yes...we need it.

ducqhl commented 2 years ago

Any update on this?

adityarai commented 2 years ago

Hi all, facing same issue.. any updates??

manishprivet commented 2 years ago

Hi all, I think the repository is dead considering the time of the last commit. I found this great codepen which utilized mui for a similar chip input.

https://codesandbox.io/s/long-morning-oubt4?file=/src/App.tsx

Danesz commented 2 years ago

I have forked the repo and made some modifications (I am not really a JS man), and I could make it work in my project like this: npm i https://github.com/Danesz/material-ui-chip-input#feature/react17 (my branch is based on the latest v2 beta tag.)

oxc commented 2 years ago

Based on @Danesz changes I created a pull request (well aware that there have not been any commits recently).

My change only expands the range of the peerDependency, there's no need to update the devDependencies.

viclafouch commented 2 years ago

Hello ! This package (https://viclafouch.github.io/mui-chips-input/) supports both React 17 / 18 and MUI V5