search

TeamWertarbyte / mdi-material-ui

Material-UI SvgIcon components for Material Design Icons.
MIT License
328 stars 15 forks source link

supports @material-ui 4.0.0 #22

Closed minhna closed 5 years ago

minhna commented 5 years ago

@material-ui version 4 is released. Could you please make an update? Thank you.

leMaik commented 5 years ago

It should work. I'll publish a new release with the updated peer dependency shortly.

minhna commented 5 years ago

thank you very much

marcberchtold commented 5 years ago

Would you also use React.forwardRef to create the icon components? Because this is required in some components in material-ui (V4). Described here: https://material-ui.com/guides/composition/#caveat-with-refs

leMaik commented 5 years ago

@minhna Just released v6.0.0 for Material-UI v4. It requires React 16.8 or later (hence the major bump). Here's a compatibility table. I'll update all three major versions for the foreseeable future.

Material-UI React mdi-material-ui
0.x any ^4.0.0
^1.0.0 any ^5.0.0
^3.0.0 any ^5.0.0
^4.0.0 ^16.8.0 ^6.0.0

@marcberchtold Great idea! :+1: I updated the component to behave like Material UI's icons, it now uses React.memo and React.forwardRef.