TRWP fails with ADB push and sideload of large file when using the latest ADB client from Google

[hselasky]

• [x] I am running an official build of TWRP, downloaded from https://twrp.me/Devices/
• [x] I am running the latest version of TWRP
• [x] I have read the FAQ (https://twrp.me/FAQ/)
• [x] I have searched for my issue and it does not already exist

Device codename: a5y17lte TWRP version: 3.5.2

WHAT STEPS WILL REPRODUCE THE PROBLEM?

adb push and adb sideload of large file will fail, due to short data received.

WHAT IS THE EXPECTED RESULT?

The ADB server in TWRP must ignore so-called Zero Length Packets, ZLPs, received via USB. Google updated their ADB client to send ZLPs to flush data buffers regularly, due to a change in RX buffering in their ADB server.

Refer to the function should_perform_zero_transfer() at: https://github.com/aosp-mirror/platform_system_core/blob/platform-tools-29.0.6/adb/client/usb_libusb.cpp#L188

I can probably make a patch if someone can point out the USB code used for ADB in TWRP.

WHAT HAPPENS INSTEAD?

Transfer aborted. Google has confirmed this is a new feature and not a bug.

[bigbiff]

Hello, we use ADB from system_core for each build tree. This patch would need to be ported to all build trees we use starting with Lollipop.