TeamWin / android_bootable_recovery

1.3k stars 408 forks source link

BAD signatures for several 3.7.0 platform downloads #277

Open SandraEickel opened 1 year ago

SandraEickel commented 1 year ago

Device codename: s5neolte TWRP version: 3.7.0_9-0

Also affected devices:

Not affected:

WHAT STEPS WILL REPRODUCE THE PROBLEM?

Download .img and corresponding .img.asc files (using FireFox).

WHAT IS THE EXPECTED RESULT?

Running gpg --verify *.img.asc returns: Good signature from "TeamWin admin@teamw.in"

WHAT HAPPENS INSTEAD?

Instead, the result is: BAD signature from "TeamWin admin@teamw.in"

ADDITIONAL INFORMATION

Earlier builds had correct signatures (only tested with s5neolte and gauguin, which has no 3.7.0). Sha256sum matches (s5neolte), also the .img.tar and corresponding .img.tar.asc are okay. The extracted recovery.img matches twrp-3.7.0_9-0-s5neolte.img, so only the signature file for the *.img file is not in sync with the other files. The platforms s5neolte, a20 and k3g are all Samsung mobile phones, addison is for a different vendor.

Suggestions: Find out where and how these incorrect signatures happen (and if more other devices are also problematic). Optimize the upload and page generation process to detect non-matching/broken file sets.

mipiro commented 1 year ago

This also affects Samsung devices a3xelte and a5xelte, just two that I checked.

Perhaps unrelated, but I was also unable to get 3.0.0_9-0 3.7.0_9-0 working on an a3xelte. The phone got stuck showing the logo on boot. The signature for the previous release 3.6.2_9-0 is good though and that version does function.

SandraEickel commented 1 year ago

You probably meant 3.7.0_9-0 (not 3.0.0_9-0). I tried that version on my S5 Neo, too. The boot ended with a black screen after the phone logo. Trying 3.6.2_9-0, TWRP works as expected. User 3Hel created issue #288 for this, but only for S5 Neo LTE, you should add that more Samsung phone models are also unusable with version 3.7.0_9-0.

Yoris1 commented 1 year ago

Also reproducible on new builds for j5xnlte. Seems like the .tar signatures are fine tho.