TeamWin / android_device_google_wahoo

For building TWRP for Pixel 2 and 2XL ONLY!
24 stars 10 forks source link

TWRP decryption issue #2

Open nico151999 opened 5 years ago

nico151999 commented 5 years ago

It seems like you cannot decrypt your data partition in the recovery as long as there is an enabled screen lock. Clean flashing ROMs and vendor featuring the security update of May 2019 or newer causes TWRP to be unable to decrypt the data partition even though the correct password/pattern/PIN is given. There are two ways to circumvent this. Firstly, you can simply remove screen lock in Android. This results in TWRP not to be required to decrypt data using a password. Secondly, you can clean flash an April 2019 build + vendor combination and update flashing dirtily. Just head over to the XDA-Thread where you can find multiple people complaining about this issue: https://forum.xda-developers.com/pixel-2-xl/development/twrp-alpha-pixel-2-xl-t3698148 I do not have the time to take a deeper look into the issue. I hope someone else will take care of it. Thank you!

aszorenyi commented 5 years ago

Same here on a Pixel 2, after june update (previously I was on the april build and it was working fine).

JohnLGalt commented 5 years ago

June update? Latest I see is 3.3.0.0 from April, for both Walleye and Taimen.

https://dl.twrp.me/walleye/

https://dl.twrp.me/taimen/

aszorenyi commented 5 years ago

Android's June security update, not TWRP.

JohnLGalt commented 5 years ago

Same here on a Pixel 2, after june update (previously I was on the april build and it was working fine).

OK, If you clean install Pie before the April Update, it was working ... sort of. You could decrypt to get access to the emulated SDCard (aka Phone storage) but trying to make Nandroid backups and restore them failed, I think on one specific part of the backup.

If you clean installed after April, it breaks TWRPs ability to decrypt.

You can always go back and clean install April, and have i working - which upgrades to May update broke (via OTA, dirty install) for a few, but mostly not. IIRC, the June update (again via OTA, dirty update) broke it for some more, but not all (I may be wrong about the June Update, though). Not sure about the July update)

However, you specifically state that you went from April to June - and that may be (at least partially) the cause of it breaking for you. IIRC, if you take the updates monthly, it's a smaller patch update, but if you skip even a single month, you get the full sized OTA - which,. instead of patching, is basically like clean installing in /system, which is similar to a full clean install, in that it breaks decryption (this is speculation on my part, as we had determined at XDA that clean installs were the first to break).

The easiest fix is to turn off screen lock right before going booting into bootloader to live boot TWRP / booting directly into TWRP. Then, do what you have to do, and then when you reboot into the system, re-enable your screen lock security.

The harder thing to do is clean install April update, verify that decryption works, and either stay on it, or don't install any apps and test - take the June OTA directly (via adb sideload) and see if it breaks. If it does, clean install April again, then manually flash the May OTA from https://developers.google.com/android/ota (remember, these are the full system OTAs, not patching ones, so these might also cause it to break). See if that helps. If it sticks, then follow up by flashing the June OTA and see if it still sticks.

Of course, all of this will remove TWRP, so if you have it installed, you'll need to install it again - but you can check the status of decryption by live booting TWRP from the bootloader menu.

Android's June security update, not TWRP.

Gotchya. My mistake on that.