Fix known issues - Githubissues

TeamWizardry / TMT-Refraction

A light manipulation based mod for The Modding Trials

MIT License

3 stars 4 forks source link

Fix known issues #62

Closed Snownee closed 5 years ago

Snownee commented 5 years ago

Improved laser rendering: Fix glitch when rendering laser far from world center

Before: https://streamable.com/fhcb0 After: https://streamable.com/nkrln

Avoid causing chunk loading in laser calculating
Grenade: Fix grenade ray-caster hitting itself
Fix JEI category gui size is too high
Recipes: add more ore dictionary supports
Fix effects:
- Burn:
  - Fix wrong smelting output
  - Fix cannot power furnace
- Attract: fix item popping from full block
- Freeze: fix wrongly implementing fire extinguishing
- Place:
  - Rewrite behavior.
  - Fix potential issue with fake player caching objects

Rikshy commented 5 years ago

Sorry @Snownee i clicked too fast and resolved the whole thing. Please answer the last open conversation, when you have time :) (just in case you didn't see there is still one open!) Also sorry for the late response, i am currently on a business trip :S

the JEI maven repo is back up so this will probably be resolved too :)

Snownee commented 5 years ago

I fixed another bug. Please review

And I found a bug with liblib: cannot print default value correctly:

Rikshy commented 5 years ago

Some of the config range stuff is fixed in liblib version 4.16 (refraction currently runs on 4.15)

SaadArdati commented 5 years ago

Is this ready for merging?

Snownee commented 5 years ago

Fixed a new bug. Please review it.

SaadArdati commented 5 years ago

This is not a bug. This is intentional to create aesthetic only beams. revert it

Rikshy commented 5 years ago

Running the beam through stained glass should not create functional beams. It's a choice of balance.

Snownee commented 5 years ago

Done. So how about remaining effect for colorless glass?