TeamWizardry / Wizardry

Delve into spell creation and become a wizard
Other
64 stars 20 forks source link

Optifine Leaves #333

Closed disastercube closed 4 years ago

disastercube commented 4 years ago

Wisdom leaves and other types of greens are not compatible with shaders waving effect.

murapix commented 4 years ago

Unsupportable feature - optifine is closed source (so we have absolutely no clue what could even be done to fix this), and our leaves are pretty much standard.

disastercube commented 4 years ago

What about removing the "Wisdom leaves" and replace them with an already existing variations such as "Dark oak leaves". The current texture of the leaves doesn't really spell Nature, magic or vanilla. By doing so, the problem would be resolved and the trees would look a bit better (if adding a new tree variation as well).

Simplified example 2020-10-17_19 17 01

murapix commented 4 years ago

Because they need to drop wisdom wood saplings, not vanilla saplings.

disastercube commented 4 years ago

You could make it so if a sapling is dropped in mana it becomes the sapling (hence the reason why wisdom trees spawn near mana pools). Also, is there a config option to set mana pool frequency spawn rate and a way to disable wisdom tree natural spawn?

murapix commented 4 years ago

That's already the case, normal saplings dropped in mana become wisdom saplings. The tree is still intended to be a completely self-contained way of creating more wisdom wood, without needing any mana.

And yes, there is a config option for the mana pool frequency, but no, there is nothing to affect the tree spawns.

disastercube commented 4 years ago

What about just changing the leaves texture. As it is right now it doesn't really fit in the game (without shaders to make it blend more in its surroundings) and it looks like a copy from many other mods that use the same leaves texture.

disastercube commented 4 years ago

Also, I'm having trouble with a setting shaders provide. You can add waving to modded leaves by yourself in the shader folder - block.properties but I'm having troubles implementing it

block. id=block1

Vanilla leaves. block.10018 = oak_leaves spruce_leaves birch_leaves jungle_leaves acacia_leaves dark_oak_leaves

murapix commented 4 years ago

The block is wizardry:wisdom_leaves - all modded blocks have a modid: prefix before the actual name (there's actually a hidden minecraft: before all vanilla blocks too, but that's just the assumed default, so usually not specified)