Error reading .mrd file

YonniFriedlander commented 2 months ago

Just getting back on the horse now and cleaning up some issues as I re-load the latest version.

In io_utils, at get_ute_mrd_files it looks for a .h5 file when loading an .mrd file.

I suggest changing it something like:

def get_dis_mrd_files(path: str) -> str: """Get list of gas exchange MRD files.

Args:
    path: str directory path of MRD files
Returns:
    str file path of MRD file
"""
try:
    return (
        glob.glob(os.path.join(path, "**dixon***.h5"))
        + glob.glob(os.path.join(path, "**dixon***.mrd"))
        )[0]
except:
    raise ValueError("Can't find MRD file in path.")

davidmummy commented 2 months ago

Hi @YonniFriedlander -- thanks for flagging this. We are totally fine with using both the .h5 and the .mrd extension per your suggestion.

We're spread thin right now though. Any chance you would want to create a branch for this at your convenience and make the code change, and then we can just check it in?

YonniFriedlander commented 2 months ago

Sure, happy to try but I've actually never done anything more exciting than just download code from GitHub so apologies if I do it wrong.

Yonni Friedlander | 647.967.7717 | St. Joseph's Healthcare Hamilton | Room T3218

From: David Mummy @.> Sent: Wednesday, September 25, 2024 10:43 AM To: TeamXenonDuke/xenon-gas-exchange-consortium @.> Cc: Yonni Friedlander @.>; Mention @.> Subject: Re: [TeamXenonDuke/xenon-gas-exchange-consortium] Error reading .mrd file (Issue #73)

Hi @YonniFriedlander -- thanks for flagging this. We are totally fine with using both the .h5 and the .mrd extension per your suggestion. We're spread thin right now though. Any chance you would want to create a branch for this at your convenience ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Hi @YonniFriedlanderhttps://urldefense.com/v3/__https://github.com/YonniFriedlander__;!!CYniXPqi!ks17mPc2a8g5htknbhTz2kGFK22MXLadKQyJl-tp1hJVuktsdR1bG8x2AwMLylT3Pailq5qA0-tX-XrR38hM_qKiNQ$ -- thanks for flagging this. We are totally fine with using both the .h5 and the .mrd extension per your suggestion.

We're spread thin right now though. Any chance you would want to create a branch for this at your convenience and make the code change, and then we can just check it in?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/TeamXenonDuke/xenon-gas-exchange-consortium/issues/73*issuecomment-2374298947__;Iw!!CYniXPqi!ks17mPc2a8g5htknbhTz2kGFK22MXLadKQyJl-tp1hJVuktsdR1bG8x2AwMLylT3Pailq5qA0-tX-XrR38gMbDoymw$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A7HQDUCZRLUJFNQZVB7YJETZYLDXJAVCNFSM6AAAAABOBYOM3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZUGI4TQOJUG4__;!!CYniXPqi!ks17mPc2a8g5htknbhTz2kGFK22MXLadKQyJl-tp1hJVuktsdR1bG8x2AwMLylT3Pailq5qA0-tX-XrR38ggmeoKKw$. You are receiving this because you were mentioned.Message ID: @.***>

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and/or privileged information. Any unauthorized review, use, copying, saving, disclosure, re-transmission or distribution is strictly prohibited. If you are not the intended recipient or this information has been inappropriately forwarded to you, please contact the sender by reply e-mail or the Privacy Office via @.*** Thank you.

davidmummy commented 2 months ago

Excellent! And no problem we'll help work through any snags. First thing to do is just to click the "create a branch" link in GitHub (on the right of the Issue) and then pull the branch to your local system via Github. Then you can make the edits on that branch and push it back to the remote branch on Github.

(Nobody's allowed to push to the main branch so there's no risk of accidentally overwriting our production code).

TeamXenonDuke / xenon-gas-exchange-consortium

Error reading .mrd file #73