search

TeamXenonDuke / xenon-gas-exchange-consortium

0 stars 1 forks source link

hb_correction overrides manual rbc:m ratio #82

Closed YonniFriedlander closed 1 week ago

YonniFriedlander commented 1 week ago

I've entered an RBC:M ratio in the config file using

self.rbc_m_ratio = 0.401

When I enter a Hb value in the config file using the following code, the RBC:M ratio printed on the report is not the value I enter manually

# set what kind of hemoglobin correction to use
self.hb_correction_key = constants.HbCorrectionKey.RBC_AND_MEMBRANE.value
# define subject hemoglobin in g/dL
self.hb = 12.5

However, when I comment out the Hb correction from the config file, the RBC:M is correctly reported as 0.401.

Other than how to fix the issue, I'm wondering if this is a reporting problem or is the wrong RBC:M propagated through the calculations?

Thanks as always, Yonni

davidmummy commented 1 week ago

Hi Yonni -- I think this is actually the expected behavior, assuming it's not going completely off the rails with your RBC:M value. The Hb correction affects both the RBC and the M values, and the Hb-corrected version is what's used in the report.

A Hb value of 12.5 is a bit lower than normal, so we'd expect the correction to bring the RBC signal UP and the membrane DOWN. The RBC:M thus gets a double whammy and gets driven upward to some degree. It shouldn't huge for an Hb of 12.5 but definitely noticeable.

Is that what you're seeing?

Note the original RBC:M is still used for the Dixon decomposition. The Hb-corrected version just gets output in the report.

YonniFriedlander commented 1 week ago

I didn't know that the code applied the Hb correct to spec results. That's perfect, thanks. My bad!

Yonni Friedlander | 647.967.7717 | St. Joseph's Healthcare Hamilton | Room T3218

From: David Mummy @.> Sent: Wednesday, November 20, 2024 4:28 PM To: TeamXenonDuke/xenon-gas-exchange-consortium @.> Cc: Yonni Friedlander @.>; Author @.> Subject: Re: [TeamXenonDuke/xenon-gas-exchange-consortium] hb_correction overrides manual rbc:m ratio (Issue #82)

Hi Yonni -- I think this is actually the expected behavior, assuming it's not going completely off the rails with your RBC: M value. The Hb correction affects both the RBC and the M values, and the Hb-corrected version is what's used in the report.  ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Hi Yonni -- I think this is actually the expected behavior, assuming it's not going completely off the rails with your RBC:M value. The Hb correction affects both the RBC and the M values, and the Hb-corrected version is what's used in the report.

A Hb value of 12.5 is a bit lower than normal, so we'd expect the correction to bring the RBC signal UP and the membrane DOWN. The RBC:M thus gets a double whammy and gets driven upward to some degree. It shouldn't huge for an Hb of 12.5 but definitely noticeable.

Is that what you're seeing?

Note the original RBC:M is still used for the Dixon decomposition. The Hb-corrected version just gets output in the report.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/TeamXenonDuke/xenon-gas-exchange-consortium/issues/82*issuecomment-2489575007__;Iw!!CYniXPqi!nNni7SzUPX57W8GC2b7Egn1BX_bnmVKQxzAbZ1_G9XwvaMNKmKKUTyOI-_ssp51wzcBvdEOh5RKDB2Bhpo4GMHUdeg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A7HQDUEQRKB6DBOSPKL3NDD2BT5GLAVCNFSM6AAAAABSFN72LOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBZGU3TKMBQG4__;!!CYniXPqi!nNni7SzUPX57W8GC2b7Egn1BX_bnmVKQxzAbZ1_G9XwvaMNKmKKUTyOI-_ssp51wzcBvdEOh5RKDB2Bhpo7zC7oUmQ$. You are receiving this because you authored the thread.Message ID: @.***>

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and/or privileged information. Any unauthorized review, use, copying, saving, disclosure, re-transmission or distribution is strictly prohibited. If you are not the intended recipient or this information has been inappropriately forwarded to you, please contact the sender by reply e-mail or the Privacy Office via @.*** Thank you.

davidmummy commented 1 week ago

No problem! Yeah I have to think it through every time to remember which way the corrections go...

Closing this bug.