[Bug] Setting Skybox Brightness & SetLightEnabled doesn't work

[vulcan-dev]

Describe the bug

I'm iterating through all lights and doing SetLightEnabled(light, false) but it doesn't work if I call SetEnvironmentProperty("skyboxbrightness", any_num) (either before or after).

Here's the full code for the lights

    local lights = FindLights("", true)
    DebugPrint("lights: " .. #lights)
    for i=1, #lights do
        local light = lights[i]
        if GetLightShape(light) then
            SetShapeEmissiveScale(GetLightShape(light), 0) -- testing
        end
        SetLightEnabled(light, false)
    end

    SetEnvironmentProperty("skyboxbrightness", 30)

SomeWhatSavageGaming told me to remove the tag nightlight from them all but that didn't work either so I'm not exactly sure if I'm missing something or if it's an actual issue.

Steps to reproduce the behavior

1. Create a simple mod that contains the above code, you can make it execute on a button press.
2. Watch the street lights/lamp posts lights stay active

Expected behavior

I would expect it to turn the lights off

Environment

• Teardown Version: 1.1.0
• OS: Windows
• GPU: RTX 2080 Super
• Graphics driver version: 516.40
• CPU: Intel Core I7-9700K

Additional context

No response

[Please-Pick-a-Name]

have you tried SetEnvironmentProperty("nightlight", false)?

[vulcan-dev]

have you tried SetEnvironmentProperty("nightlight", false)?

I have not no, didn't know that was a thing. I'll try it later and let you know 👍

[YuLun-bili]

have you tried SetEnvironmentProperty("nightlight", false)?

Adding this does disables all lights but the bug submitted is still quite interesting.

• SetLightEnabled() along would turn off all lights no matter what weather properties set to (lights want to be enabled will flash for one tick)
• SetLightEnabled() and SetEnvironmentProperty("skyboxbrightness", NUMBER) would make those (lights) with tag night remain enabled. Parent shapes would not be emissive however (not set by script).

test script:

function tick()
    if not InputDown("backspace") then return end
    local lights = FindLights("", true)
    for i=1, #lights do
        local light = lights[i]
        SetLightEnabled(light, false)
    end

    local nightLights = FindLights("night", true)
    for i=1, #nightLights do DrawShapeOutline(GetLightShape(nightLights[i]), 1, 0.45, 0, 1) end

    -- SetEnvironmentProperty("nightlight", false)
    SetEnvironmentProperty("skyboxbrightness", 0)
end