search

Teardown-Issue-Tracker-Maintainers / Teardown-Issue-Tracker

A public repo for the community to track issues/bugs/feature requests in Teardown.
12 stars 6 forks source link

[Bug] Unlabeled hyperlink in mod description activates unexpectedly #578

Open Malar10 opened 2 weeks ago

Malar10 commented 2 weeks ago

Describe the bug

An unlabeled link in a mod description will send the player to it's address when pressing other buttons

video of me performing the bug (link expires in 2 days, please tell me if you need another) https://streamable.com/qkw504

Hereis the mod I used in the video

Steps to reproduce the behavior

  1. Aquire mod with a description consisting only of an unlabeled https link example description in info.txt: description = [[http://www.example.com]]

  2. Open mod manager and click on the mod Notice the description looks empty image

  3. Click out of mod manager

  4. Try to open mod manager again

  5. Get sent to the link's address without your consent

Expected behavior

The link should not do anything if the player doesn't click on it

Also unlabeled links should not be invisible, but instead display the target address Normally this does happen, but only if there is also other text in the description

description = a[[http://www.example.com;]] image the above description shows normally and does not unexpectedly send the player to a website

Environment

Additional context

No response

nooitaf commented 2 weeks ago

This should have been communicated privately, as in.. "responsable disclosure". Why is it even possible to put a link in there at all???

Malar10 commented 2 weeks ago

You're right, I may not have thought of all the implications of this bug.

Also links and hyperlinks are a documented feature (for some reason) https://teardowngame.com/modding/api.html#UiText

YuLun-bili commented 2 weeks ago

we got the new web link format since 1.5.4 (around Mar 4th) when they changed method of handling link to game's modding website in mod manager.

Gregory-Gregory commented 2 weeks ago

@Malar10 hi!

Thank you for reporting this issue. I have shared the information with the QA team.

Unfortunately, the link is not available anymore. Can you please send it an as attachment or upload it to a Google Drive?

Malar10 commented 2 weeks ago

@Gregory-Gregory hi I've uploaded the video to google drive Here's the link: https://drive.google.com/file/d/1soVNGpuxmrcw_93VL3la_mwtP7TcNgHM/view?usp=sharing

Gregory-Gregory commented 2 weeks ago

@Malar10 thank you! I have added the video to the investigation.