TeaspoonTDA / teaspoon

Topological Signal Processing in Python
https://teaspoontda.github.io/teaspoon/
GNU General Public License v3.0
23 stars 9 forks source link

Ditch most of the Persistence.py file #5

Closed lizliz closed 1 year ago

lizliz commented 2 years ago

The code in teaspoon.TDA.Persistence.py is largely legacy code from before we had nice python wrappers for ripser. This part of the package can be largely dumped since there's so little chance we'd use some of the more outdated persistence computation packages.

Even the code in there for doing Ripser is my own (sloooooooooooooow) code for reading in the text file outputs from the C++ ripser package. I doubt anything else in teaspoon is using those versions, but we'd also just have to make sure there were not lingering dependencies.

barnesd8 commented 1 year ago

There are only a few helper functions with minimal external dependencies, and none of these are tda libraries, so I've removed anything unnecessary and left the helper functions that are used or that could be helpful. Screenshot of functions left is below.

Screenshot 2023-01-02 at 1 24 35 PM