TecKnow / muster-tools

A package for assigning players to tables at multi-table, walk-in gaming events.
GNU General Public License v3.0
0 stars 0 forks source link

Investigate upgrading immutable.js #6

Closed TecKnow closed 4 years ago

TecKnow commented 4 years ago

immutable.js has been on release candidates for some time now. This project currently uses the latest non-RC version of immutable.js. The documentation for the library assumes the use of the RC though, and it has some convenient features.

The last time an upgrade was considered, chai-immutable, which this project uses for test assertions on immutable.js objects, was not compatible with the RC versions. Investigate if this has changed.

If it has, please upgrade immutable.js, otherwise document that and open a new issue for removing chai-immutable from the project.

TecKnow commented 4 years ago

I tried updating to the immutable version 4 release candidate and redux-forms started throwing dependency warnings for the latest stable version of immutable as well.

npm WARN chai-immutable@2.1.0 requires a peer of immutable@^3.0.0 but none is installed. You must install peer dependencies yourself.

npm WARN redux-form@8.3.1 requires a peer of immutable@^3.8.2 but none is installed. You must install peer dependencies yourself.

I could see if it works anyway, but I'm less inclined to do that for a production dependency.

The alternative to using chai-immutable was straightforward, if tedious. Remove chai-immutable and convert immutable objects to POJO in assertions. The performance hit should not matter much for testing purposes.

It is unclear what the alternative to using redux-forms would be, and I do not think it would be productive to investigate at this time.

I'm going to close this issue.