Tech-N-Science / FunwithScience

MIT License
125 stars 218 forks source link

Springs Combination Calculator #637

Closed Sukriti-m closed 2 years ago

Sukriti-m commented 2 years ago

Related Issue

Fixes: #550

Describe the changes you've made

I have added a calculator for calculating equivalent spring constant for a combination of springs both in series and parallel.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot

spring2

spring1

spring

Video

https://user-images.githubusercontent.com/93239528/166159629-249e1b45-c7ef-43b7-a9da-60afbd5cb142.mp4

@Amit366 Please review this PR.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @Sukriti-m :)

AnuragParashar2000 commented 2 years ago

hey @Sukriti-m , when we input value in the second column and then click calculate , the popup don't show up. Please Check. image

Sukriti-m commented 2 years ago

hey @Sukriti-m , when we input value in the second column and then click calculate , the popup don't show up. Please Check. image

I have made the required changes. Please review it now.

AnuragParashar2000 commented 2 years ago

Hey @Sukriti-m , make the showsolution as false when one of the input field is empty, as when I click calculate the popup shows up this time which was not there earlier, but the solution opens up, so make the show solution as false when one input filed or both input fields are empty.