Tech-N-Science / FunwithScience

MIT License
125 stars 218 forks source link

Added the solution #704

Closed jatin00000 closed 2 years ago

jatin00000 commented 2 years ago

Related Issue

Fixes: #640

Describe the changes you've made

Updated editorialdata.js with solution added to Question for Physics with id 1,2,3,4,5,8,22,23,27,33.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot
github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @jatin00000 :)

Amit366 commented 2 years ago

@jatin00000 have u copied directly from any website?

jatin00000 commented 2 years ago

No, For Numerical, only took some symbols. For reasoning, only i took some reference. Not directly copied.

github-actions[bot] commented 2 years ago

Thank you @jatin00000 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :).

Amit366 commented 2 years ago

@jatin00000 see the question id starts from 0 and not 1, so change that and also in some multiple correct questions u haven't shown all answers which are correct. And also the editorial is not opening for numerical type. So once check that

jatin00000 commented 2 years ago

OK, I will do it.

Amit366 commented 2 years ago

@jatin00000 see u can first send a PR with the changed index number. And then another PR for numerical editor. So that it counts 3 PRs

jatin00000 commented 2 years ago

https://github.com/Tech-N-Science/FunwithScience/pull/705 Thank you, For providing me the opportunity to work on this project.

Amit366 commented 2 years ago

@jatin00000 i am glad that u liked this project 😊. U can work on the editor section of numerical questions.

Amit366 commented 2 years ago

And yes do star this repo