search

TechAtNYU-Deprecated / website

Whoo!
MIT License
3 stars 2 forks source link

When the menu is toggled in small viewport, it doesn't re-open for large viewports #2

Open wylieconlon opened 11 years ago

wylieconlon commented 11 years ago

Thoughts on how to fix this?

revivek commented 11 years ago

Do you mean when turning a device sideways?

Does the JavaScript break?

— Sent from phone

On Sat, Mar 2, 2013 at 6:40 PM, Wylie Conlon notifications@github.com wrote:

Thoughts on how to fix this?

Reply to this email directly or view it on GitHub: https://github.com/TechAtNYU/website/issues/2

wylieconlon commented 11 years ago

You can test this by resizing your browser window. If you start small, open then close the menu, and then scale it up, the menu stays hidden

On Sunday, March 3, 2013, Vivek Patel wrote:

Do you mean when turning a device sideways?

Does the JavaScript break?

— Sent from phone

On Sat, Mar 2, 2013 at 6:40 PM, Wylie Conlon <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>

wrote:

Thoughts on how to fix this?

Reply to this email directly or view it on GitHub: https://github.com/TechAtNYU/website/issues/2

— Reply to this email directly or view it on GitHubhttps://github.com/TechAtNYU/website/issues/2#issuecomment-14348028 .

revivek commented 11 years ago

Ah yes, I see. Okay I'll take a look at it. I think it might have something to do with different CSS selectors being activated/deactivated.

On Sun, Mar 3, 2013 at 2:09 PM, Wylie Conlon notifications@github.comwrote:

You can test this by resizing your browser window. If you start small, open then close the menu, and then scale it up, the menu stays hidden

On Sunday, March 3, 2013, Vivek Patel wrote:

Do you mean when turning a device sideways?

Does the JavaScript break?

— Sent from phone

On Sat, Mar 2, 2013 at 6:40 PM, Wylie Conlon <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>

wrote:

Thoughts on how to fix this?

Reply to this email directly or view it on GitHub: https://github.com/TechAtNYU/website/issues/2

— Reply to this email directly or view it on GitHub< https://github.com/TechAtNYU/website/issues/2#issuecomment-14348028> .

— Reply to this email directly or view it on GitHubhttps://github.com/TechAtNYU/website/issues/2#issuecomment-14352665 .

Vivek Patel 914.356.0778 · 1.vivekpatel@gmail.com · @revivekhttp://www.twitter.com/revivek

ghost commented 11 years ago

Just pushed a fix that should work with IE10 and all other major browsers.

Can someone verify this?

wylieconlon commented 11 years ago

@htian I would much rather use a breakpoint in pixels (not 35em) and have something that works in all browsers period. Less to worry about.

revivek commented 11 years ago

I 'm not sure about the reasoning behind 35em but it is part of the HTML5 Boilerplate, which I assume has been refined with best practices.

http://html5boilerplate.com/

On Wed, Mar 6, 2013 at 1:06 AM, Wylie Conlon notifications@github.comwrote:

@htian https://github.com/htian I would much rather use a breakpoint in pixels (not 35em) and have something that works in all browsers period. Less to worry about.

— Reply to this email directly or view it on GitHubhttps://github.com/TechAtNYU/website/issues/2#issuecomment-14484333 .

Vivek Patel 914.356.0778 · 1.vivekpatel@gmail.com · @revivekhttp://www.twitter.com/revivek

wylieconlon commented 11 years ago

Nope, according to https://github.com/h5bp/html5-boilerplate/issues/1321 it's totally arbitrary. So we can, and should, replace that with our own values if we have reason to. Which we do.

revivek commented 11 years ago

Oh, wow, nice catch. Haha, okay sounds good. Does 480px sound good?

On Wed, Mar 6, 2013 at 1:11 AM, Wylie Conlon notifications@github.comwrote:

Nope, according to https://github.com/h5bp/html5-boilerplate/issues/1321it's totally arbitrary. So we can, and should, replace that with our own values if we have reason to. Which we do.

On Wed, Mar 6, 2013 at 1:08 AM, Vivek Patel notifications@github.comwrote:

I 'm not sure about the reasoning behind 35em but it is part of the HTML5 Boilerplate, which I assume has been refined with best practices.

http://html5boilerplate.com/

On Wed, Mar 6, 2013 at 1:06 AM, Wylie Conlon notifications@github.comwrote:

@htian https://github.com/htian I would much rather use a breakpoint in pixels (not 35em) and have something that works in all browsers period. Less to worry about.

— Reply to this email directly or view it on GitHub< https://github.com/TechAtNYU/website/issues/2#issuecomment-14484333> .

Vivek Patel 914.356.0778 · 1.vivekpatel@gmail.com · @revivek< http://www.twitter.com/revivek>

—

Reply to this email directly or view it on GitHub< https://github.com/TechAtNYU/website/issues/2#issuecomment-14484384> .

— Reply to this email directly or view it on GitHubhttps://github.com/TechAtNYU/website/issues/2#issuecomment-14484432 .

Vivek Patel 914.356.0778 · 1.vivekpatel@gmail.com · @revivekhttp://www.twitter.com/revivek