search

TechAtNYU / tech-nyu-site

https://techatnyu.org
8 stars 5 forks source link

Add SW information to techatnyu.org #48

Closed rgardner closed 10 years ago

rgardner commented 10 years ago
  1. Add Startup Week poster as background splash image when first landing on the site. @abhinayashutosh
  2. Add announcements box with link to nyusw.com site, similar to lexilewtan.com @freialobo

@ethanresnick @grungerabbit @abhiagar can one of you try these changes on your computer? Look for image problems with the startup week poster and for how to make the announcements box look better.

PR for issue #46

ethanresnick commented 10 years ago

Thanks a lot for working on this!

I really like the idea of a background splash, but the text is getting cut off in the current version at many screen ratios. (See attached.) screen shot 2014-10-31 at 8 18 36 pm We could fix this by making wide and narrow background images. And, if you have time to do that, then please do! But, if you don't, I think we can go back to the old images and just have the announcement bar as the promo. Either way, though, please save the code you wrote, as linked bg images is something we'll likely want in the future!

Re the announcement bar, there are a few style fixes needed, I think. I'll send a PR to your branch documenting them.

freialobo commented 10 years ago

the announcement box looks awesome. thanks @rgardner :-)

grungerabbit commented 10 years ago

Thank you @rgardner for putting this together, and on Halloween, too! If the poster isn't working out, maybe we could get a photo from today's events and use that for splash imagery? What do you think?

@freialobo tbt that time I designed lexilewtan.com

freialobo commented 10 years ago

hey! we need to remove this tomorrow night :)

rgardner commented 10 years ago

I created a fix here: 32a09aed0fffb154cc6704615f635c93003e7e32. We can just merge this in tomorrow night.