Closed purplefox closed 11 years ago
Thanks @purplefox!
deployModule('vertx.mongo-persistor-v1.2.1', persistorConf, 8)
. Is this doing it wrong or do I misunderstand? (Note, I didn't write the Vert.x test, so I apologize if my response is way off the mark.)As for the testing approach:
Thanks for taking the time to review this. We especially appreciate it when the framework/platform authors themselves can help us improve the tests.
I must be going blind. I didn't even see the App.groovy, just saw the WebServer.java! Apologies.
Regarding the general points
Ha! We'd be happy to have 10 GBE but it's not in the cards, so to speak.
Several tests do not yet implement the database tests. But as for dropping the Vert.x database test, I'll discuss this with my colleagues since that's an unprecedented request and I'd like some more opinions about that. The request certainly carries weight coming from the author of a framework, but I'm not sure I agree with removing data for that reason alone. I'll follow up later.
Incidentally, you can filter the results to view only platforms using Mongo:
Don't worry about removing the results, after all it's a free(ish) world and you can publish whatever you want ;)
However, I do still have real concerns about the benchmarks and whether they're actually benchmarking the system under test, and whether they really reflect what people would actually do with the framework.
Haven't tried this, but you might get somewhat better perf in the vert.x database tests by increasing the number of mongodb module instances you deploy from 8 to somewhere around 20 or 30.
@purplefox Thanks for the recommendation and for being open to seeing the data live on despite your misgivings with the project as a whole.
The approach we are taking exercises building blocks of web applications in admittedly unrealistic scenarios of repeated requests to do the same trivial operations. As I have written elsewhere, it means we receive criticism from fans of full-stack frameworks for not testing a realistic fully-conceived web application (e.g., a blog or a web store) and criticism from platform developers for needing to snap on best-of-breed components such as JSON serializers or database drivers in order to fulfill our quite-small requirements.
I believe for all the caveats, it remains valuable to know the rough performance characteristics of the building blocks one is likely to use with a particular selection, whether they come as part of the package "off the shelf" or must be selected from a suite of bolt-on options. Where there is not yet consensus on the preferred building blocks, we have been happy to see the addition of more variations (e.g., Play+Anorm and Play+JPA).
With time, we will gradually add more tests to exercise more pieces, and some of those tests may make progress toward the more fully-conceived application test desired by full-stack fans.
@pfalls1 If you find the time prior to Round 6, can you give a quick test to the recommendation of 20-30 mongodb module instances?
I am just cleaning up old issues. I believe this issue is superseded by Round 7 vert.x work.
I just looked at the Vert.x setup... At first glance there appear to be some issues, including:
Other than that there seem to be more general issues with the testing approach, unless I am missing something including: