The react app now builds before the django app so Django can manage those static assets with collectstatic. I think this was the root of the problem before.
I've also added Sentry (raven) for exception handling. It looks like once we add an OSS (MIT, Apache, etc) license to the project we should be able to get a team account for free from them.
One other thing in this PR is update to the app.json which Heroku reads for deployments. A key thing I missed in their docs was that you can inherit env variables from the parent project (in this case the staging app) if you set that as an object. If the value is a String in the app.json it will override whatever value the parent has. You see that here with our SENTRY_DSN entry in app.json, the review apps will inherit that key from the staging app.
It seems like the review apps could also use staging's database but I'm not sure how that would work with migrations. If opened a PR it would run them against Staging which may not be the best way to do it.
Once we promote this one up to staging and we create DB logins they should be able to start entering data.
It is fine to run DB migrations on each deploy right? I haven't used Postgres in a while and just wanted to make sure.
The react app now builds before the django app so Django can manage those static assets with
collectstatic
. I think this was the root of the problem before.I've also added Sentry (raven) for exception handling. It looks like once we add an OSS (MIT, Apache, etc) license to the project we should be able to get a team account for free from them.
One other thing in this PR is update to the
app.json
which Heroku reads for deployments. A key thing I missed in their docs was that you can inherit env variables from the parent project (in this case the staging app) if you set that as an object. If the value is a String in theapp.json
it will override whatever value the parent has. You see that here with our SENTRY_DSN entry in app.json, the review apps will inherit that key from the staging app.It seems like the review apps could also use staging's database but I'm not sure how that would work with migrations. If opened a PR it would run them against Staging which may not be the best way to do it.
Once we promote this one up to staging and we create DB logins they should be able to start entering data.
It is fine to run DB migrations on each deploy right? I haven't used Postgres in a while and just wanted to make sure.