TechGrounds-Cloud8 / cloud8-archana-sekarr

cloud8-archana-sekarr created by GitHub Classroom
0 stars 0 forks source link

Python 04-07 Feedback Request: #60

Closed archana-sekarr closed 2 years ago

archana-sekarr commented 2 years ago

Feedback Request [Python 04-07] Permalink to file: [[LINK]

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-04-Loops1.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-04-Loops2.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-04-Loops3.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-05-Conditions1.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-05-Conditions2.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-06-Functions1.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-06-Functions2.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-06-Functions3.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-07-Lists1.py

https://github.com/TechGrounds-Cloud8/cloud8-archana-sekarr/blob/main/Python/PRG-07-Lists2.py)]

Template for peers for review:

**Summary**
- Does the summary describe the subject matter fully?
- Is the summary written in own words?
- Is there crucial information missing in the summary?
- Is the description clear enough?

**Key Terminology**
- Are there missing key terms?
- Are the key terms explained well?

**Sources**
- Are the sources mentioned?
- Are the mentioned sources correct?

**Excercise**
(Where applicable)
- Is the result correct?
- Are the experienced problems and solutions described well?

Share the link to this issue with your peers.

benbui797 commented 2 years ago

Well done! The style/layout looks good and follows the python best practises, it makes it very readable and easy to review :) Also your comments are very clear, thank you!

Conditions2: There are some imports on top that aren't used, so it's a best practise to remove them (probably they got auto-imported by VSC)

QuincyTjia commented 2 years ago

Well done! like the last feedback I gave, your comments are spot on. Your code is very good.