No way to install DirectPlay Voice (dpvoice.dll, dpvvox.dll)

[GoogleCodeExporter]

Some Wine bugs, like this one,[1] disappear when both dpvoice.dll and 
dpvvox.dll are installed and registered. Winetricks needs an option to install 
these two DLLs. Maybe they could be integrated into the directplay or directx9 
installer, or maybe we need a new dpvoice installer.

[1] https://bugs.winehq.org/show_bug.cgi?id=29238

Original issue reported on code.google.com by alexhenr...@gmail.com on 29 Dec 2014 at 10:13

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Hi, I've created a patch for the 'dpvoice' verb for patch consideration. The 
one thing I'm concerned about is the naming in the metadata.

The dpvoice verb loads and overrides dpvoice.dll and dpvvox.dll as suggested 
from the dxnt.cab in the source directx_feb2010_redist.exe source.

Here's the files shown in a 64bit wine prefix:
~/.wine/drive_c/windows/syswow64$ ll dpvoice.dll dpvvox.dll
-rw-rw-r-- 1 dude dude 381952 Dec 12  2002 dpvoice.dll
-rw-rw-r-- 1 dude dude 112128 Dec 12  2002 dpvvox.dll

I've also attached the changes in a '.verb' file, so that could be used instead.

Cheers!

Original comment by Shannon....@gmail.com on 3 Jan 2015 at 4:01

[GoogleCodeExporter]

Fixing this bug is particularly important because DirectPlay Voice is patented, 
so a complete free software implementation may not be possible for years to 
come:

https://www.google.com/patents/US7720908
https://www.google.com/patents/US7730206

What is the next step to getting your 'dpvoice' verb accepted?

Original comment by alexhenr...@gmail.com on 5 Jan 2015 at 7:13

[GoogleCodeExporter]

Austin or I have to review and apply it.   (My time for Wine stuff is pretty 
limited
these days, mostly I just do winetricks releases.)

Original comment by daniel.r...@gmail.com on 5 Jan 2015 at 4:22

• Changed state: Started

[GoogleCodeExporter]

dpvacm.dll should probably be included too.

Original comment by alexhenr...@gmail.com on 12 Jan 2015 at 11:12

[GoogleCodeExporter]

Hi Alex, I've attached updated my patch to include dpvacm.dll.

Cheers!

Original comment by Shannon....@gmail.com on 14 Jan 2015 at 12:36

Attachments:

• winetricksdpvoice11415.gitdiff
• winetricksdpvoice11415.verb
• winetricksdpvoice

[GoogleCodeExporter]

https://code.google.com/p/winetricks/source/detail?r=458028f7bebdc5d241cc09cbe3b
0284f5a67336e

Original comment by austinenglish@gmail.com on 14 Jan 2015 at 10:40

• Changed state: Fixed

[GoogleCodeExporter]

Thank you!

Original comment by alexhenr...@gmail.com on 15 Jan 2015 at 2:08

[GoogleCodeExporter]

Wait a minute, did you mean to repeat installed_file2 here, or should 
dpvacm.dll have been installed_file3?

    installed_file2="$W_SYSTEM32_DLLS_WIN/dpvvox.dll" \
    installed_file2="$W_SYSTEM32_DLLS_WIN/dpvacm.dll"

Original comment by alexhenr...@gmail.com on 15 Jan 2015 at 2:50

[GoogleCodeExporter]

Bah, my bad.  I don't think winetricks uses beyond installed_file1 yet (per a 
TODO I think), but I should have caught the error. Sorry about that.

Original comment by Shannon....@gmail.com on 15 Jan 2015 at 3:03

[GoogleCodeExporter]

Sorry to digress from this issue but.. 

I noticed the FIXME note for installed_file2 was suggested on the flash verb:

# FIXME: update winetricks_is_installed to look at installed_file2
w_metadata flash ...

And I think it was to check 2 installed files to confirm the verb was 
installed? This makes me wonder if we should be checking for more than 2? Would 
winetricks need to iterate through multiple instances, e.g., installed_file*, 
or just 2?

Regardless, installed_file2 is not implemented (from what I can see), yet. If 
we can figure out whether we should be checking beyond 2 installed files, I'd 
be glad to give adding functionality in a try.

Original comment by Shannon....@gmail.com on 15 Jan 2015 at 4:09

[GoogleCodeExporter]

It should iterate over any defined installed_file#, and check for their 
presence. Patches welcome :)

Original comment by austinenglish@gmail.com on 16 Jan 2015 at 4:53