TechIsHiring / techishiring-website

A space where great Engineers and great jobs can find each other! We're on Twitter and LinkedIn and have a newsletter on Substack!
https://www.techishiring.com
MIT License
52 stars 34 forks source link

Refactor out header checks in homepage E2E tests #165

Open dgodongm opened 1 year ago

dgodongm commented 1 year ago

Description

Created validateHeader util module with helper methods similar to validateFooter, and updated homepage E2E tests to use these, adding distinct test for mobile as well.

Related Issue

121 - provides some E2E coverage instead of component as it seems there's technical impediment for the latter - see comments in this issue

Motivation and Context

Ensure more consistent approach between footer and header checks. And, adding some coverage for modal menu on mobile.

How Has This Been Tested?

Tested locally on Chrome

Screenshots (if appropriate):

n/a

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @TechIsHiring on Vercel.

@TechIsHiring first needs to authorize it.

dgodongm commented 1 year ago

@chadstewart @marktnoonan What do you think of this refactoring, and additional mobile test?

dgodongm commented 1 year ago

Thanks @marktnoonan! @chadstewart - any feedback or are you good with merging?

dgodongm commented 11 months ago

@chadstewart @marktnoonan Can this be merged?

marktnoonan commented 11 months ago

@chadstewart this needs you to authorize the Vercel step. Or I can merge without that since it's just tests.

dgodongm commented 11 months ago

@chadstewart Friendly ping on this PR