Closed TORlN closed 8 months ago
Hey @TORlN this is mostly fine as is, but since I want to also make this a learning exercise for you, I'll be more thorough than normal and advise on some best practices.
CHANGELOG.md
is auto generated from a tool called symantic release so no need to edit that one. You can leave the changes, they will be overwritten next time I do a release.
I triggered the build process to run, and the Super Linter failed. I don't think that was your changes - but would you mind cleaning that up as part of this PR? Again, don't worry about CHANGELOG. https://github.com/TechNickAI/AICodeBot/actions/runs/6551811343/job/17797440429?pr=101
The name of the branch is just "working". People use a more descriptive branch name that is specific to the task. Read up on best practices for naming a branch. Don't change it for this one, just FYI for future work.
Good to know, I’ll work on cleaning up the super linter.
Thanks for taking the time to help me out.
On Tue, Oct 17, 2023 at 2:32 PM Nick Sullivan @.***> wrote:
Hey @TORlN https://github.com/TORlN this is mostly fine as is, but since I want to also make this a learning exercise for you, I'll be more thorough than normal and advise on some best practices.
1.
CHANGELOG.md is auto generated from a tool called symantic release https://github.com/semantic-release/semantic-release so no need to edit that one. You can leave the changes, they will be overwritten next time I do a release. 2.
I triggered the build process to run, and the Super Linter failed. I don't think that was your changes - but would you mind cleaning that up as part of this PR? Again, don't worry about CHANGELOG. https://github.com/TechNickAI/AICodeBot/actions/runs/6551811343/job/17797440429?pr=101 3.
The name of the branch is just "working". People use a more descriptive branch name that is specific to the task. Read up on best practices for naming a branch. Don't change it for this one, just FYI for future work.
— Reply to this email directly, view it on GitHub https://github.com/TechNickAI/AICodeBot/pull/101#issuecomment-1767224486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJTFOTIDFWKOXHMEK7QLJ3X732QJAVCNFSM6AAAAAA6EK5LESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGIZDINBYGY . You are receiving this because you were mentioned.Message ID: @.***>
I added a newline character to line 194 in the readme because super-linter was complaining about that line being over 400 characters. I also specified, on line 219, that the code below was a shell command to appease super-linter.
I left all changelog errors alone.
Looks good. Thank you for your first contribution @TORlN!
replaced all instances of the string "gorillamania" with "TechNickAI"