search

TechReborn / RebornCore

Reborn Core is a library used for many of the Tech Reborn team's mods, including Tech Reborn, Quantum Storage, Fluxed Redstone, Hardcore Map Reset, and many more.
MIT License
44 stars 51 forks source link

Support for LibCD tag defaults #147

Closed LemmaEOF closed 2 years ago

LemmaEOF commented 4 years ago

LibCD 2.4.0+ adds a system for getting a "default" value from a tag, for the purposes of recipe outputs or loot table drops. Since JSON can't easily be modified at runtime to support LibCD or not-LibCD, RebornRecipes might want to have soft dependence on this system. I think the best solution would be for RebornRecipes to take both an "item" and a "tag" field, with "tag" being used if LibCD is present and "item" otherwise. I can PR this in soon; I just want to file it here so the system can be discussed.

drcrazy commented 2 years ago

Lemma, LibCD abandoned. Hope it is less drama now and you are fine ^_^