search

TechReborn / RebornCore

Reborn Core is a library used for many of the Tech Reborn team's mods, including Tech Reborn, Quantum Storage, Fluxed Redstone, Hardcore Map Reset, and many more.
MIT License
44 stars 51 forks source link

[1.16.1] Recipe condition "tag" broken #159

Open Sturmlilie opened 4 years ago

Sturmlilie commented 4 years ago

The "tags" condition cannot be relied upon anymore. This expression in the testing lambda:

ItemTags.getContainer().getEntries()

always returns an empty map. I tried experimenting with a bit:

Set<Identifier> entries = ItemTags.method_29214(BlockTags.getContainer());

which gives me all vanilla-registered item tags at least, but no modded ones. This breaks eg. Blockus compatibility.

Sturmlilie commented 4 years ago

blockus_marble_tempfix.zip

Above is a datapack that temporarily fixes the compatibility (marble grinding) with blockus. Note that earlier report of problems with not being able to craft crude storage units from barrels is very likely also caused by this bug, as the recipes for blockus barrels -> storage unit aren't being loaded either.

Linguardium commented 4 years ago

make sure you are testing in production, there is a bug with tags in development mode where any tag file used will overwrite any other one (even with replace:false) meaning adding things to vanilla tags will replace those tags in dev only

Sturmlilie commented 4 years ago

How is development mode defined? I mostly test my stuff by compiling to jar and launching the game from MultiMC

Linguardium commented 4 years ago

running from intellij for example. or from gradlew runclient.

running from multimc should work fine