search

TechReborn / RebornCore

Reborn Core is a library used for many of the Tech Reborn team's mods, including Tech Reborn, Quantum Storage, Fluxed Redstone, Hardcore Map Reset, and many more.
MIT License
44 stars 51 forks source link

[1.12.2] RecipeHandler findAndApply method ignores NBT for chemical reactor and centrifuge #162

Open skyline918 opened 4 years ago

skyline918 commented 4 years ago

Hello, this issue related to https://github.com/TechReborn/TechReborn/issues/2182 , but there was no activity for 30 days. The point is one can use any type of cells in these machines (even empty ones), and crafting starts anyway, using first matching recipe with available count. I surrounded Recipe recipe = recipeHandler.findAndApply(inputs, true); (https://github.com/TechReborn/TechReborn/blob/614e10c280fe71b9d457ed6037026196e0441dac/src/main/java/techreborn/tiles/processing/TileMachine.java#L189) with prints , and wrong recipe was found on runtime.

TR: 2.27.3 (cloned from branch 1.12) RC: 3.19.4.529

image

MerrittK commented 3 years ago

They released a build in may where they said they fixed it on the 1.12 branch. But this is still an issue now. https://github.com/TechReborn/TechReborn/commit/698dfee031f78abf4c34d1756acf2695fcf5ea19

It effectively breaks tech reborn on 1.12 entirely, since the unaffected machines are duplicating IC2 functionality already.