search

TechSmith / mp4v2

Fork of mp4v2: https://code.google.com/archive/p/mp4v2/
Other
284 stars 135 forks source link

Fix GCC7 build #36

Closed ffontaine closed 2 years ago

ffontaine commented 4 years ago

if (*pSlash != '\0') {

As it stands the body of that if will always execute and when there are no encoding parameters ppEncodingParams will be returned as a pointer to an empty string rather than as a null pointer

Signed-off-by: Peter Korsgaard peter@korsgaard.com [Retrieved from: https://git.buildroot.net/buildroot/tree/package/mp4v2/0001-Fix-GCC7-build.patch] Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Anton-Latukha commented 4 years ago

@TechSmith

True, this patch was required to build projects both on Arch Linux https://git.archlinux.org/svntogit/packages.git/plain/trunk/libmp4v2-c++11.patch?h=packages/libmp4v2, and in Nixpkgs ("master" store state of NixOS).

You can see that 4.1.3 is currently available only on Arch Linux derivatives, so this patch allowed the use of this package for them, and not with this patching would also be in Nixpkgs.

Arch Linux and NixOS are the best downstream testing grounds, so with this patch package would be picked-up by all other distros.

Anton-Latukha commented 4 years ago

Fedora also uses this patch: https://src.fedoraproject.org/rpms/libmp4v2/raw/d7aeedabb/f/0004-Fix-GCC7-build.patch

ryandesign commented 2 years ago

You can close this; it was already committed in 8d6307ea1e70c0a44dd2a64c4fa1a8f42b803ebf.