search

TechStarHub / meme-gen

A Meme generating website written in React, for React Beginner
https://memegeno.netlify.app/
MIT License
2 stars 5 forks source link

Fix the Hamburger Menu Icon 🛠️ #6

Closed iamBijoyKar closed 10 months ago

iamBijoyKar commented 10 months ago

Fix the Hamburger Menu

Follow the figma design and make these changes.

image

Changes

zablon-oigo commented 10 months ago

I can tackle this , please assign me

iamBijoyKar commented 10 months ago

Go for it 👍

zablon-oigo commented 10 months ago

Go for it 👍

Do you have a design that you might prefer ? Or I should come up with my own

iamBijoyKar commented 10 months ago

Use the provided figma design in Readme

zablon-oigo commented 10 months ago

hello Here is my submission, I would like to hear your review before pushing it Screen Shot 2023-11-09 at 18 58 26

iamBijoyKar commented 10 months ago
  1. Align the menu icon with the brand logo
  2. Give a little margin in the right of the menu icon

The rest is good 👌

zablon-oigo commented 10 months ago

How about now

  1. Align the menu icon with the brand logo
  2. Give a little margin in the right of the menu icon

The rest is good 👌

How about now Screen Shot 2023-11-09 at 19 31 16

iamBijoyKar commented 10 months ago

Much better 👍, make a PR