TechStark / opencv-js

OpenCV JavaScript version for node.js or browser
Apache License 2.0
353 stars 31 forks source link

Incorrect type for minMaxLoc #21

Closed pbowyer closed 9 months ago

pbowyer commented 1 year ago

Thanks for putting together this library, it's great to have a version that can be imported and that has type support.

Now I'm using it in a strictly type-checked project I've found an incorrect type. minMaxLoc is reported as

function minMaxLoc(src: cv.Mat, minVal: any, maxVal?: any, minLoc?: any, maxLoc?: any, mask?: cv.Mat | undefined): void (+1 overload)

but when I use it it returns an object

const minMaxLoc = cv.minMaxLoc(grayImage)
ttt43ttt commented 9 months ago

Fixed in v4.8.0-release.6