search

TechStudent10 / DiscordRPC

RPC mod for Geode
11 stars 10 forks source link

Incorrect Difficulty for rated levels with differing star count #1

Closed Aktimoose closed 11 months ago

Aktimoose commented 12 months ago

For any rated level, the mod will determine the difficulty to show in the RPC with the star count. This causes an issue with a few levels, namely the main levels (with every level that's 10 stars or greater just being NA) (it also just leaves the creator section blank) image image image

As well as Luster by eopc (which is easy rated) image

This no star auto level also has an incorrect difficulty idk why image

TechStudent10 commented 12 months ago

The RobTop levels I'm planning on fixing (already reported to me in a Discord server) + they are the only (non-hacked) rated levels in the game with a star count <10 so I can probably hard code it if I really have to.

As for Luster I'm probably going to leave it because it's an issue on Rob's end, as well as it being such a rare edge case.

The no-star auto thing is probably due to the fact that I use the enum that GD uses to determine icon faces in the event that a level is unrated (stars = 0). It must be set to display the hard face for some reason. Again, an edge case.

TechStudent10 commented 12 months ago

@Aktimoose can you send me the ID for the auto no-star level?

Aktimoose commented 12 months ago

@Aktimoose can you send me the ID for the auto no-star level?

503047

TechStudent10 commented 11 months ago

I'm not sure what the issue is for the auto no star level tbh. It's difficulty face is set to the hard face even though in game it shows up as auto. I'd most likely have to hard-code this in, which for such a rare level really doesn't matter. Main levels were fixed in commits https://github.com/TechStudent10/DiscordRPC/commit/bd498696dbf7bdec9eb5f3cddf0fa7979dc1b2de and https://github.com/TechStudent10/DiscordRPC/commit/a2adf547f2fe579a17847d00295421d5763a9165, so I'm gonna go ahead and close this issue.