search

TechTeamer / docker-manager-library

1 stars 0 forks source link

The dockerOptions parameter should be optional #3

Closed kukko closed 3 months ago

kukko commented 3 months ago

https://github.com/TechTeamer/docker-manager-library/blob/6f1086e1d29ddf6be3c29355c51db78d47afc48e/src/docker.ts#L17-L19

Since the constructor instantiates a Docker instance from the dockerode npm package where the parameter of the Docker class is optional, we shouldn't make it stricter than it is in the dockerode package.

notcurse commented 3 months ago

Fixed in the draft PR: https://github.com/TechTeamer/docker-manager-library/pull/4