TechWiz-3 / who-unfollowed-me

😡 Python CLI tool that shows you who has unfollowed you on GitHub. PRs welcome!

GNU General Public License v3.0

11 stars 24 forks source link

Added for Hindi #19

Closed ShivanshDengla closed 1 year ago

ShivanshDengla commented 1 year ago

Description

Put changes made - link an issue if relevant

Type of change

Please delete options that are not relevant. For the item that is relevant mark it completed as - [x] text here

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

E.g.

manually running the program on the localhost

Checklist:

Mark as completed - [x] text here

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings

ShivanshDengla commented 1 year ago

Hey, I updated for Hindi, but i am doing this for the first time so i didn;t know how to correctly code it. I just copied english and changed the Hindi lines, do let me know if theres any mistake, i'll try to correct it. Thanks

TechWiz-3 commented 1 year ago

This is perfect except please remove line 52 locale = "hindi". Otherwise everything is perfect.

The locale = <language> statement is for the user to configure which language they want to see i.e. English or Hindi

ShivanshDengla commented 1 year ago

This is perfect except please remove line 52 locale = "hindi". Otherwise everything is perfect.

The locale = <language> statement is for the user to configure which language they want to see i.e. English or Hindi

Hey, Thanks for the comment, i removed line 52. Do let me know if anything else needs changed. this is my first time participating in hacktober so hope i didn't do any mistake. Thanks.

TechWiz-3 commented 1 year ago

Nah this is perfect brother. Congrats ;)

ShivanshDengla commented 1 year ago

Nah this is perfect brother. Congrats ;)

ok thanks, do you need to put hacktober accepted label here, or its fine?

TechWiz-3 commented 1 year ago

I can but it's not necessary because the repo has the hacktoberfest topic on it. Some people like it so that's why I have it

ShivanshDengla commented 1 year ago

Thank you so much.

TechWiz-3 commented 1 year ago

All good man :)