Closed TimTemi closed 1 year ago
C'mon is that seriously the best you can do? Adding a single comment to a single file?
And your comment isn't formatted properly, you should make it all lowercase and put a space between the #
and the text.
I appreciate wanting to contribute and participate in Hacktoberfest but it's becoming tedious as a maintainer reviewing PRs with literally no added value.
If you wish me to accept this PR, add another 20 comments and make sure your changes don't fail the checks. You can test this with poetry run black
or poetry run flake8
after installing the development environment as specified in the CONTRIBUTING.md
@TechWiz-3 , Sorry you have to go through every PR, with no value added. Yeap, my first time contributing to Open source project, I guess the YouTube tutorial didn't teach me better, indeed one can also learn through contributing to open source projects. I just learned how to actually comment out a line and also understand the actually meaning and uses of this check boxes. Thank you 😊
Oh, the 'checks' I'm talking about are these
They automatically check the codebase for style errors that make the code harder to read. In this case they failed because the comment you added doesn't confirm to the style guide.
If you click the Details
link on the 4th check Linting / flake8 (3.10) (pull_request)
and look in the logs you can see.
./unfollow/unfollow.py:64:1: E265 block comment should start with '# '
./unfollow/unfollow.py:65:1: E302 expected 2 blank lines, found 1
Info on linting: https://www.perforce.com/blog/qac/what-lint-code-and-why-linting-important Info on GitHub Actions: https://www.youtube.com/watch?v=R8_veQiYBjI
@TechWiz-3 , I guess I still have a lot to learn. I'll watch the tutorial, thanks for sharing😊, encountering mistakes and learning through them. I'm sorry it had to be project. I'll delete the commit and anything connected to it.
that's alright, don't worry about it
i admire your perseverance, keep at it 🔥
Thanks
Commented
Description
Type of change
How Has This Been Tested?
Checklist: