TechWiz-3 / who-unfollowed-me

😡 Python CLI tool that shows you who has unfollowed you on GitHub. PRs welcome!
GNU General Public License v3.0
11 stars 24 forks source link

Update unfollow.py to check if a user no longer exists #8

Closed lyer1 closed 1 year ago

TechWiz-3 commented 1 year ago

Niceee 🔥

One change please:

result+="[deleted]" -> result = f"{result} [deleted]" - just a personal preference

lyer1 commented 1 year ago

Niceee 🔥

One change please:

result+="[deleted]" -> result = f"{result} [deleted]" - just a personal preference

Sure! I've changed as you proposed, please review.

TechWiz-3 commented 1 year ago

Sorry to request changes again 😅 i didn't pay proper attention the first time

Since the 'link' is built from result when we add [deleted] to result it also gets added to the link when it's built. result=f"{result} [deleted]" is perfect, but let's make another variable before that line that's something like result_for_link = result And then below that change unfollowers.append((result,f"https://github.com/{result}/")) -> unfollowers.append((result,f"https://github.com/{result_for_link}/"))

One other change... for those using tokens please change the request to include headers=HEADERS [line 104]

lyer1 commented 1 year ago

Oh yeah, my bad I'll fix the issues.

TechWiz-3 commented 1 year ago

Perfecto, thanks a lot and congrats on your first PR 🥳 🥳

TechWiz-3 commented 1 year ago

Little tip for the future, when you submit a PR that solves the issue, consider a little message in the description like Solves #<issue num> 😁

lyer1 commented 1 year ago

Little tip for the future, when you submit a PR that solves the issue, consider a little message in the description like Solves #<issue num> 😁

Thanks for guiding me. And sorry for not mentioning issue. I did the same thing just now, sent a PR to one more repo without the issue or without getting assigned, and the maintainer got annoyed 😭.

TechWiz-3 commented 1 year ago

Nahhhh issok man not a problem at all, just a little tip :))

lyer1 commented 1 year ago

Nahhhh issok man not a problem at all, just a little tip :))

okk thanks! also just wondering if you could add the hacktoberfest-accepted lable to this PR.

TechWiz-3 commented 1 year ago

Sure I can, but i don't think that's necessary coz i already have the hacktoberfest tab on the repo