Techern-archived / Igneous-Extras

A revival of the Igneous Additions mod for Minecraft 1.10.2 and beyond
http://minecraft.curseforge.com/projects/igneous-extras
MIT License
2 stars 1 forks source link

Tools [WIP] #20

Closed HoldYourWaffle closed 8 years ago

HoldYourWaffle commented 8 years ago

So I was done with my big-crawler refactor, and figured I could go working on this =)

(I'll be adding more commits to this today [it's 10AM here now])

(it may be handy to squash merge this cause else you get all kind of "Merge remote-blablabla" commits in your history)

HoldYourWaffle commented 8 years ago

Nice we got almost the same coding style =)

HoldYourWaffle commented 8 years ago

Should I just add Andesite/Diorite/Granite tools or more variants? (haven't done coloring yet at all)

CruzBishop commented 8 years ago

Thanks for starting work on this :) I'll cherry pick the two commits you started off with so far and go from there

It's up to you, I was going to work on a little script to make dyed blocks (and I guess items) a lot easier to generate when I get some time off next week, so just diorite/andesite/granite should be okay for now :+1:

If anything major comes up, I'll send you a pull request - but from what I've seen so far, you'll do good :)

HoldYourWaffle commented 8 years ago

I'll do diorite/andesite/granite for now, and do the dyed stuff when your script is done :)

CruzBishop commented 8 years ago

Sounds good, thank you :)

CruzBishop commented 8 years ago

Sorry if you get spammed by notifications in a minute, I'm going to try something on here and I'm not sure if it will work

HoldYourWaffle commented 8 years ago

No problem. Was just going to lunch.

CruzBishop commented 8 years ago

Mmm, lunch. You're making me hungry again :cake:

I think I just sent you the right access request, then if you accept you'll be able to pull/push directly from here and End Deco if you want (otherwise it might make it easier to do a hard reset to develop)

There's another way to do it as well, but it's easier this way :)

Enjoy your lunch, I might go find something to chew on then come back and play around a bit

HoldYourWaffle commented 8 years ago

Back again, joined Techern. I can just create a feature branch now right? (never worked in a team before)

CruzBishop commented 8 years ago

Thank you :)

Yeah, you should be right to pull develop and start a feature branch now if you want :+1:

HoldYourWaffle commented 8 years ago

I'm gonna try something so this PR needs to be closed.

CruzBishop commented 8 years ago

Alright, good luck :)

I just merged the first batch of pressure plates into develop so sorry if that messed anything up

HoldYourWaffle commented 8 years ago

That's part of the reason why i'm trying this ;)

I don't mind tho, I'm not very experienced with git(hub) so still need to learn alot

CruzBishop commented 8 years ago

:)

All good, the great thing about git is that if something goes wrong, somebody somewhere will have a history of a working copy :page_facing_up:

HoldYourWaffle commented 8 years ago

Try-thingy succeeded =)

Now I have my crawler & IE in 1 workspace

CruzBishop commented 8 years ago

That's great :grinning:

Should make it easier, thank you again for helping :)

HoldYourWaffle commented 8 years ago

I like this project (played IA already) and I like opensource. Good combi isn't it?

CruzBishop commented 8 years ago

Yep, it sure is :)

I'm about to start on slabs again but I also just took some painkillers for my toes, if I fall asleep have a great afternoon / night - One more day of work then two off :+1:

HoldYourWaffle commented 8 years ago

Haha :smile:

Btw what version number schould I use in the since tags for my feature?

CruzBishop commented 8 years ago

Oops, I tagged it as 0.9 :p I'll change it in a sec

Should be right to do @since 0.0.2