search

Techeron / vlr_api

An unofficial API for vlr.gg
MIT License
4 stars 1 forks source link

ReWrite Backend in Bun + Fastify + TS #1

Open Codokk opened 1 year ago

honjes commented 7 months ago

Hey, I would like to use this API. Would you mind if I start with porting it ?

honjes commented 7 months ago

Hey, I'm currently working on the types of the player scraper and I have a question: What is the purpose of adding additional stats (agentStats) to the player object ?

Would love to hear your reasoning behind this.

Codokk commented 7 months ago

Good morning!

My goal was to minimize the amount of requests and maximize the data pulled. Agentstats was a welcome byproduct, and made it easy to figure out with a single request who plays what and their 30d stats

~ Cody Krist

On Fri, Apr 12, 2024 at 10:33 PM Clara @.***> wrote:

Hey, I'm currently working on the types of the player scraper and I have a question: What is the purpose of adding additional stats (agentStats) to the player object ?

Would love to hear your reasoning behind this.

— Reply to this email directly, view it on GitHub https://github.com/Techeron/vlr_api/issues/1#issuecomment-2053036456, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPPJ7I3CQHWVC3QFK2CFP3Y5CKN7AVCNFSM6AAAAAA772FRFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTGAZTMNBVGY . You are receiving this because you were assigned.Message ID: @.***>

Codokk commented 7 months ago

Also, I would recommend if you want (imo) a better valorant api, use this one (which was the rewrite) https://github.com/Techeron/fvlr_api

honjes commented 7 months ago

Ok, thanks for the response. I'm gonna look at the rewrite and probably use that one then. Maybe you could add a link to the README to redirect other people that are interested.