Cleanup - Githubissues

TechforgoodCAST / tech-for-good-near-you

an app to find tech for good events near you

https://tech-for-good-near-you.herokuapp.com/

MIT License

11 stars 2 forks source link

Cleanup #58

Closed andrewMacmurray closed 7 years ago

andrewMacmurray commented 7 years ago

Some general cleanup to make elm code more like PUK project

move significant model update logic into Data files
separate http logic into Request folder
google map div is always in dom, initialised when app is booted but hidden when not on results view
rejig css for map and results, results now scroll with main page (fixes offset problems at bottom of page with vh on safari)

andrewMacmurray commented 7 years ago

lol

andrewMacmurray commented 7 years ago

forgot to mention that the results view on mobile isn't quite fixed yet, will work on that next so we can deploy it again

ivan-unfolds commented 7 years ago

Sounds good. Btw yesterday I put some elm tests that we had written into the phoenix test folder. I saw that there is now a elm/Test folder, I am guessing this where they should go now?

andrewMacmurray commented 7 years ago

yep, that sounds good