search

TechmanRobotInc / tmr_ros1

TM Robots supporting ROS1 drivers and some extended external applications. (experimental) (not support the new TM S-Series)
Other
49 stars 21 forks source link

Do not install the config folder in tm_driver #6

Closed Yuki-cpp closed 2 years ago

Yuki-cpp commented 3 years ago

Hello,

When trying to integrate the ros package to an application build in install mode, the build for tm_driver failed because it could not install the non existent config folder.

Since the folder doesn't exist the install directive can safely be removed.

Yuki-cpp commented 3 years ago

@kentsai0319 Any feedback on this? This issue makes this repository incompatible with a broader ROS ecosystem. Could you consider merging this fix?

Thank you

Yuki-cpp commented 2 years ago

@leoWuTmRobot I understand you're the current maintainer of this repo? Could you have a look at this? I'm happy to make any change that you see fit :)

Thank you

leoWuTmRobot commented 2 years ago

Dear Yuki:

According to our company’s policy, all questions should be reply to our proxy or sales and them can give you a reply.

If I didn’t get the replay from our proxy or sales, I don’t have any resource to add new feature or fix problem.

But about this problem, I can fix it on next commit within 3 week.

So, please wait a few days, once I finish this, I will info you.

From: Leo @.> Sent: Friday, May 6, 2022 9:27 AM To: TechmanRobotInc/tmr_ros1 @.> Cc: leo.wu 吳如峰 @.>; Mention @.> Subject: Re: [TechmanRobotInc/tmr_ros1] Do not install the config folder in tm_driver (#6)

@leoWuTmRobothttps://github.com/leoWuTmRobot I understand you're the current maintainer of this repo? Could you have a look at this? I'm happy to make any change that you see fit :)

Thank you

— Reply to this email directly, view it on GitHubhttps://github.com/TechmanRobotInc/tmr_ros1/pull/6#issuecomment-1119183271, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASOZE6FFFOMYSFHYRRE7KDDVIRYP5ANCNFSM4U7K6Z6Q. You are receiving this because you were mentioned.Message ID: @.**@.>>