TechmanRobotInc / tmr_ros2

TM Robots supporting ROS2 drivers and some extended external applications. (experimental) (not support the new TM S-Series)
Other
36 stars 21 forks source link

Colcon build failed #39

Open daeronhing opened 5 months ago

daeronhing commented 5 months ago

:dove: :dove: :dove: :dove: :dove: :dove: Thanks for taking the time to fill out this issue report! :dove: :dove: :dove: :dove: :dove: :dove:

Summarize Fresh colcon build of the repo, ran into error.

Contact details soonhing.low@crowndigital.io

TM App Version tmr_ros2 Humble 1.0.6

To Reproduce Steps to reproduce the bug:

  1. Create a new workspace
  2. Clone tmr_ros2 (humble branch) into workspace
  3. Modify name of tmr_ros2 to src
  4. Run colcon build --symlink-install
  5. Error appears

Reproducibility Fresh installation of tmr_ros2

Expected behavior/code Build successful.

Relevant logs and screenshots tmrobot_build_error

Environment

Possible Solution In send_command.cpp line 24

if(rclcpp::spin_until_future_complete(node, res_future) != rclcpp::executor::FutureReturnCode::SUCCESS)

Change to

if(rclcpp::spin_until_future_complete(node, res_future) != rclcpp::FutureReturnCode::SUCCESS)
TechmanRobotIncOwner commented 5 months ago

Hi, Low Soon Hing sir,

Thank you for your report.

In the humble code 1.0.6, you can download it, by the command "git clone https://github.com/TechmanRobotInc/tmr_ros2.git -b humble" It can be found that the code is correct.

Or look directly at the web page code below. (Line 24) https://github.com/TechmanRobotInc/tmr_ros2/blob/humble/custom_package/src/send_command.cpp

[cid:a8442781-486b-48e8-9191-e809eff3928f]

Thanks


寄件者: Low Soon Hing @.***> 寄件日期: 2024年3月13日 下午 05:42 收件者: TechmanRobotInc/tmr_ros2 副本: V_ROS-I_owner; Assign 主旨: [TechmanRobotInc/tmr_ros2] Colcon build failed (Issue #39)

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ Thanks for taking the time to fill out this issue report! 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

Summarize Fresh colcon build of the repo, ran into error.

Contact details @.**@.>

TM App Version tmr_ros2 Humble 1.0.6

To Reproduce Steps to reproduce the bug:

  1. Create a new workspace
  2. Clone tmr_ros2 (humble branch) into workspace
  3. Modify name of tmr_ros2 to src
  4. Run colcon build --symlink-install
  5. Error appears

Reproducibility Fresh installation of tmr_ros2

Expected behavior/code Build successful.

Relevant logs and screenshots tmrobot_build_error.png (view on web)https://github.com/TechmanRobotInc/tmr_ros2/assets/31173368/f3e4d7f5-9aab-4571-8b80-f692dbfc475b

Environment

In send_command.cpp line 24

if(rclcpp::spin_until_future_complete(node, res_future) != rclcpp::executor::FutureReturnCode::SUCCESS)

Change to

if(rclcpp::spin_until_future_complete(node, res_future) != rclcpp::FutureReturnCode::SUCCESS)

— Reply to this email directly, view it on GitHubhttps://github.com/TechmanRobotInc/tmr_ros2/issues/39, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APUY4S6HL4NF2MGGLZBNGPLYYANRTAVCNFSM6AAAAABETZPLPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DGNJUGI4TMOA. You are receiving this because you were assigned.Message ID: @.***>