search

TechnicJelle / BlueMapCustomSkinProvider

Minecraft Paper plugin and BlueMap addon for using a custom skin server with BlueMap
Mozilla Public License 2.0
1 stars 4 forks source link

Cerothen patch 1 #2

Closed Cerothen closed 1 year ago

Cerothen commented 1 year ago

this is a patch that adds in skinsrestorer support since there are no other plugins that provide that funcationality for the BlueMapAPI V2 and SkinsRestorerAPI V15.

TechnicJelle commented 1 year ago

Wow! That's a big feature! :o However, I don't think this feature is a good fit for my Custom Skin Provider plugin. Why not keep your plugin split off from mine? So people can use your SkinsRestorer plugin if they want SkinsRestorer integration, and they can use my Custom Skin Provider if they want to use a fully custom skin server. That would also make your life a bit easier, as you won't have to keep supporting a custom skin URL. You probably won't even need a config file at all, anymore!

Cerothen commented 1 year ago

I thought about your comments and you might be right, since I could have been somewhat more deliberate about import choices the resulting JAR was larger than I had originally hoped. I am newer on the java side and what packages there are so I will have to par that down in the future.

I developed and expanded an alternative:

https://github.com/Cerothen/BlueMapSkinIntegration

TechnicJelle commented 1 year ago

Nice!

I would like to also mention that if you're using any code of mine, you have to mention it to abide by the MPL License of my project. You can read it here. The simplest way to comply would be to just mention that your plugin uses code from/is based on this one, with a hyperlink back to this repository. You can put it in the readme of your project.